Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: restore merge split ranges with small data #53595

Open
wants to merge 5 commits into
base: release-8.3
Choose a base branch
from

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented May 28, 2024

What problem does this PR solve?

Issue Number: close #53532

Problem Summary:
br restore splits too many regions if there are too many small tables whose data size is less than region size.

What changed and how does it work?

ignore some keys to split less regions
image
image
image
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2024
Copy link

tiprow bot commented May 28, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.3@1a0c3ac). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.3     #53595   +/-   ##
================================================
  Coverage               ?   50.9061%           
================================================
  Files                  ?       1700           
  Lines                  ?     610186           
  Branches               ?          0           
================================================
  Hits                   ?     310622           
  Misses                 ?     276094           
  Partials               ?      23470           
Flag Coverage Δ
integration 23.0564% <76.9230%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.1894% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 48.5225% <0.0000%> (?)

@Leavrth
Copy link
Contributor Author

Leavrth commented Jul 19, 2024

stuck by tikv/tikv#17278

@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 1, 2024

closed by #55104

@Leavrth Leavrth closed this Aug 1, 2024
@Leavrth Leavrth reopened this Nov 2, 2024
@Leavrth Leavrth changed the base branch from master to release-8.3 November 2, 2024 11:17
Copy link

ti-chi-bot bot commented Nov 2, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Nov 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from leavrth, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 2, 2024

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-ddl-test 4eab96a link true /test pull-integration-ddl-test
pull-br-integration-test 4eab96a link true /test pull-br-integration-test
pull-mysql-client-test 4eab96a link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/check_dev f9ba925 link true /test check-dev
idc-jenkins-ci-tidb/unit-test f9ba925 link true /test unit-test
idc-jenkins-ci-tidb/build f9ba925 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
1 participant