table/tables: fix a DATA RACE in TestHashPartitionAddRecord

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #53678

Problem Summary:

What changed and how does it work?

After a add a table.Table to cache, it should be read-only and immutable.
But currently the Cols() function use lazy-initialization, it initialize (write) some fields and cause read-write confliction, and the data race.

This change avoid the lazy-initialization way, initialize all the fields when creating table.Table.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

cd pkg/table/tables/test/partition/
go test -race -tags intest -c
./partition.test -test.run ^TestHashPartitionAddRecord$

DATA RACE is not easy to reproduce stability.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.1044%. Comparing base (a48a4a2) to head (a77598d).
Report is 11 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53798         +/-   ##
=================================================
- Coverage   72.6973%   56.1044%   -16.5929%     
=================================================
  Files          1551       1673        +122     
  Lines        437184     611205     +174021     
=================================================
+ Hits         317821     342913      +25092     
- Misses        99756     244984     +145228     
- Partials      19607      23308       +3701     

Flag	Coverage Δ
integration	37.2774% <91.6666%> (?)
unit	71.8352% <91.6666%> (+0.1255%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5212% <ø> (+6.6807%)	⬆️

[hawkingrei]

/ok-to-test

[tiancaiamao]

/test check-dev2

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

/test unit-test

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/test all

[tiancaiamao]

close #54651

[D3Hunter]

/hold

need fix comments

[River2000i]

close #54377

[tiancaiamao]

Updated and remove the unnecessary old syn.Once
PTAL @zimulala @D3Hunter

[tiancaiamao]

/unhold

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [zimulala]
• pkg/table/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-04 10:04:26.115328015 +0000 UTC m=+3375619.872463585: ☑️ agreed by hawkingrei.
• 2024-06-07 07:47:04.348291218 +0000 UTC m=+105178.401603143: ☑️ agreed by xhebox.
• 2024-07-03 08:17:55.265739566 +0000 UTC m=+1398801.751228398: ✖️🔁 reset by zimulala.
• 2024-07-17 06:12:19.55621778 +0000 UTC m=+420761.547159241: ☑️ agreed by zimulala.
• 2024-07-18 06:32:55.868229455 +0000 UTC m=+508397.859170925: ☑️ agreed by hawkingrei.

[tiancaiamao]

/retest