hint: avoid duplicate hints in QBHintHandler (#53921) #53935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
13 tasks
ti-chi-bot
bot
added
size/XXL
ti-chi-bot
bot
added
size/S
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
cherry-pick-53921-to-release-7.1
branch
from
e11b683
to
76a1ed9
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
approved these changes
Jul 5, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
1 similar comment
|
/retest |
qw4990
approved these changes
Jul 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
size/M
Signed-off-by: Weizhen Wang <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #53935 +/- ##
================================================
Coverage ? 73.5510%
================================================
Files ? 1211
Lines ? 380934
Branches ? 0
================================================
Hits ? 280181
Misses ? 82952
Partials ? 17801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #53921
What problem does this PR solve?
Issue Number: close #53767
Problem Summary:
What changed and how does it work?
QBHintHandler may produce duplicate hints. When it reaches the match stage, the first one will be marked as a hint, but the second one will be ignored, ultimately resulting in incorrect warning messages.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.