ddl: clear MDL related tables for create view #53944
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53944 +/- ##
=================================================
- Coverage 72.5455% 55.7643% -16.7813%
=================================================
Files 1508 1628 +120
Lines 431744 603533 +171789
=================================================
+ Hits 313211 336556 +23345
- Misses 99128 243840 +144712
- Partials 19405 23137 +3732
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
| @@ -228,3 +228,38 @@ func TestUpgradingRelatedJobState(t *testing.T) { | |||
| dom.DDL().StateSyncer().UpdateGlobalState(context.Background(), &syncer.StateInfo{State: syncer.StateNormalRunning}) | |||
| } | |||
| } | |||
|
|
|||
| func TestGeneralDDLWithQuery(t *testing.T) { | |||
| store, _ := testkit.CreateMockStoreAndDomain(t) | |||
There was a problem hiding this comment.
| store, _ := testkit.CreateMockStoreAndDomain(t) | |
| store := testkit.CreateMockStore(t) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, hawkingrei, lance6716, tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53246
Problem Summary:
What changed and how does it work?
create view as select xx, create table also has for syntax foras select, but it's not implemented.1. alter table a add column xxx; 2. create view v as select * from a, they will block each other if we don't clear the MDL. also see ddl: manage job lifecycle in worker #53747 (comment)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.