Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: updating stats cache can trigger evict #53979

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 12, 2024

What problem does this PR solve?

Issue Number: close #53742

Problem Summary:

What changed and how does it work?

ristretto will evict the data when inserting data. If LFU meets high-update scenes, it cannot evict. so we need to write some entry value to trigger the value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9258%. Comparing base (7b8c91d) to head (6817953).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53979         +/-   ##
=================================================
- Coverage   74.5983%   55.9258%   -18.6725%     
=================================================
  Files          1508       1628        +120     
  Lines        358417     603451     +245034     
=================================================
+ Hits         267373     337485      +70112     
- Misses        71723     242826     +171103     
- Partials      19321      23140       +3819     
Flag Coverage Δ
integration 37.3240% <100.0000%> (?)
unit 53.3364% <100.0000%> (-20.1497%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 50.6231% <ø> (+6.7133%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-12 15:41:35.821937618 +0000 UTC m=+565649.875249542: ☑️ agreed by winoros.
  • 2024-06-13 03:01:27.976843265 +0000 UTC m=+606442.030155190: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 2ee6d22 into pingcap:master Jun 13, 2024
23 checks passed
@hawkingrei hawkingrei deleted the fix_update branch June 13, 2024 06:01
@hawkingrei
Copy link
Member Author

/cherrypick release-8.1
/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #53991.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 13, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #53992.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB OOM when SyncLoad statistics in the manytables scenario
4 participants