Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: delete TiFlash placement rules in batch #54071

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jun 18, 2024

What problem does this PR solve?

Issue Number: close #54068

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve performance of GC worker by deleting TiFlash placement rules in batch

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
Copy link

tiprow bot commented Jun 18, 2024

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.1640%. Comparing base (8ee4897) to head (5556e74).
Report is 4 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54071         +/-   ##
=================================================
- Coverage   72.8670%   56.1640%   -16.7031%     
=================================================
  Files          1516       1636        +120     
  Lines        434796     606981     +172185     
=================================================
+ Hits         316823     340905      +24082     
- Misses        98428     243017     +144589     
- Partials      19545      23059       +3514     
Flag Coverage Δ
integration 37.2373% <0.0000%> (?)
unit 72.0469% <84.6153%> (+0.1841%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7250% <ø> (+6.5922%) ⬆️

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @ywqzzy @zimulala

@ti-chi-bot ti-chi-bot bot requested review from ywqzzy and zimulala June 18, 2024 06:31
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2024
Copy link

ti-chi-bot bot commented Jun 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-19 03:51:30.80944084 +0000 UTC m=+173217.294929671: ☑️ agreed by tangenta.
  • 2024-06-19 06:18:48.503537333 +0000 UTC m=+182054.989026162: ☑️ agreed by GMHDBJD.

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jun 19, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Jun 19, 2024

@Lloyd-Pottiger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 570f3b4 link true /test tidb_parser_test
fast_test_tiprow 570f3b4 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jun 19, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit d1f2671 into pingcap:master Jun 19, 2024
21 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the delete-placement-rule-batch branch June 19, 2024 09:37
@JaySon-Huang
Copy link
Contributor

@Lloyd-Pottiger describes your enhancement in the release note please

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 20, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

@Lloyd-Pottiger describes your enhancement in the release note please

done

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Jul 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #54406.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54407.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #54408.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #54409.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 3, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2024
Lloyd-Pottiger added a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete TiFlash placement rules in gc worker may take a long time
5 participants