-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: correct the erroneous scalar function equivalence check (#54067) #54121
expression: correct the erroneous scalar function equivalence check (#54067) #54121
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54121 +/- ##
================================================
Coverage ? 71.1637%
================================================
Files ? 1465
Lines ? 421532
Branches ? 0
================================================
Hits ? 299978
Misses ? 101059
Partials ? 20495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990, tangenta, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #54067
What problem does this PR solve?
Issue Number: close #53726
Problem Summary:
What changed and how does it work?
when planer call
RemoveUnnecessaryFirstRow
. it will check the expression betweenAgg
andGroupBy
. but it doesn't check the return type. so it get wrong unnecessaryFirstRow
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.