-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, executor: fix index lookup join's inner index order should should be correctly mapped to join keys #54249
Conversation
…mapped to join keys Signed-off-by: AilinKid <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
// eg: join(b,a), idx1(a,b,c) | ||
// since we need to keep the join keys order, so we need to reorder the outers keys offset to make it | ||
// if outer keys don't follow the inner index's order. | ||
orderByIdxOffset2KeyOff[idxOff] = idxOff2KeyOffMap[idxOff] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main change is here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54249 +/- ##
=================================================
- Coverage 72.9282% 56.0804% -16.8478%
=================================================
Files 1523 1638 +115
Lines 435564 605535 +169971
=================================================
+ Hits 317649 339587 +21938
- Misses 98420 242564 +144144
- Partials 19495 23384 +3889
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AilinKid <[email protected]>
@AilinKid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
after we discussion with the execution team, we are going to deprecate the index_merge_join hint. |
What problem does this PR solve?
Issue Number: close #54064
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.