-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add CloneForPlanCache method to Plan interface #54295
planner: add CloneForPlanCache method to Plan interface #54295
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54295 +/- ##
=================================================
- Coverage 72.8487% 55.9905% -16.8582%
=================================================
Files 1524 1644 +120
Lines 435759 607397 +171638
=================================================
+ Hits 317445 340085 +22640
- Misses 98715 244042 +145327
- Partials 19599 23270 +3671
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: 二手掉包工程师 <[email protected]>
…90/tidb into instance-level-plan-cache-4
/test unit-test |
@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
pkg/planner/core/physical_plans.go
Outdated
@@ -736,7 +755,7 @@ type PhysicalIndexScan struct { | |||
// The index scan may be on a partition. | |||
physicalTableID int64 | |||
|
|||
GenExprs map[model.TableItemID]expression.Expression | |||
genExprs map[model.TableItemID]expression.Expression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why make it for lower case?
in a later pkg move, the physical operator will be moved out of the core, and elements inside should exported for usage.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #54057
Problem Summary: planner: add
CloneForPlanCache
method to Plan interfaceWhat changed and how does it work?
planner: add
CloneForPlanCache
method to Plan interfaceCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.