Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add CloneForPlanCache method to Plan interface #54295

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 28, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: add CloneForPlanCache method to Plan interface

What changed and how does it work?

planner: add CloneForPlanCache method to Plan interface

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels Jun 28, 2024
Copy link

tiprow bot commented Jun 28, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 68.05556% with 23 lines in your changes missing coverage. Please review.

Project coverage is 55.9905%. Comparing base (b9a31b2) to head (d7bb66e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54295         +/-   ##
=================================================
- Coverage   72.8487%   55.9905%   -16.8582%     
=================================================
  Files          1524       1644        +120     
  Lines        435759     607397     +171638     
=================================================
+ Hits         317445     340085      +22640     
- Misses        98715     244042     +145327     
- Partials      19599      23270       +3671     
Flag Coverage Δ
integration 37.0793% <0.0000%> (?)
unit 71.7984% <68.0555%> (-0.0533%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7556% <ø> (+6.5904%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 28, 2024

/test unit-test

Copy link

tiprow bot commented Jun 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -736,7 +755,7 @@ type PhysicalIndexScan struct {
// The index scan may be on a partition.
physicalTableID int64

GenExprs map[model.TableItemID]expression.Expression
genExprs map[model.TableItemID]expression.Expression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make it for lower case?

in a later pkg move, the physical operator will be moved out of the core, and elements inside should exported for usage.

Copy link

ti-chi-bot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2024
Copy link

ti-chi-bot bot commented Jun 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-28 04:32:49.518454056 +0000 UTC m=+953296.003942887: ☑️ agreed by hi-rustin.
  • 2024-06-28 07:14:51.019933951 +0000 UTC m=+963017.505422782: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 28, 2024

/retest

Copy link

tiprow bot commented Jun 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit fda7c76 into pingcap:master Jun 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants