-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/ut.go: add concurrent when listing pkgs #54306
Conversation
Hi @HuSharp. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
14ff17f
to
ce068cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54306 +/- ##
=================================================
- Coverage 74.8294% 56.6628% -18.1667%
=================================================
Files 1516 1644 +128
Lines 360862 622740 +261878
=================================================
+ Hits 270031 352862 +82831
- Misses 71259 246487 +175228
- Partials 19572 23391 +3819
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: husharp <[email protected]>
ce068cf
to
9432360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@HuSharp: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Ref #30822
Problem Summary:
What changed and how does it work?
We can list pkg concurrently to accelerate build
check result
before
after
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.