Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: speed up reader for some tables #54333

Merged
merged 13 commits into from
Jul 22, 2024
Merged

infoschema: speed up reader for some tables #54333

merged 13 commits into from
Jul 22, 2024

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jul 1, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #50305

Problem Summary:

What changed and how does it work?

Push down some filters for：

  1. infoschema.TableStatistics
  2. infoschema.TablePartitions
  3. infoschema.TableSequences
  4. infoschema.TableCheckConstraints
  5. infoschema.TableTiDBCheckConstraints
  6. infoschema.TableTiDBIndexUsage
  7. infoschema.TableTiDBIndexes
  8. infoschema.TableViews
  9. infoschema.TableConstraints
  10. infoschema.TableSchemata

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 1, 2024
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 1, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ok-to-test Indicates a PR is ready to be tested. labels Jul 1, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 1, 2024

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 75 lines in your changes missing coverage. Please review.

Project coverage is 57.4158%. Comparing base (761b592) to head (f2d67a7).
Report is 198 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #54333         +/-   ##
=================================================
- Coverage   72.8839%   57.4158%   -15.4682%     
=================================================
  Files          1523       1678        +155     
  Lines        435584     639005     +203421     
=================================================
+ Hits         317471     366890      +49419     
- Misses        98568     248540     +149972     
- Partials      19545      23575       +4030
Flag Coverage Δ
integration 39.8628% <44.0000%> (?)
unit 71.8084% <33.0827%> (-0.0870%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4088% <ø> (+5.2503%) ⬆️

@ywqzzy ywqzzy changed the title [WIP]infoschema: acc reader [WIP]infoschema: acc reader for some Jul 1, 2024
@ywqzzy ywqzzy changed the title [WIP]infoschema: acc reader for some infoschema: acc reader for some tables Jul 1, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jul 1, 2024
@ywqzzy ywqzzy changed the title infoschema: acc reader for some tables infoschema: speed up reader for some tables Jul 1, 2024
@ywqzzy ywqzzy changed the title infoschema: speed up reader for some tables [DNM]infoschema: speed up reader for some tables Jul 1, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2024
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 2, 2024

/retest

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 2, 2024

/retest

@ywqzzy ywqzzy changed the title [DNM]infoschema: speed up reader for some tables infoschema: speed up reader for some tables Jul 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2024
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 3, 2024

/retest

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 3, 2024

/retest

lance6716
lance6716 reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 / 5 files viewed

pkg/planner/core/memtable_predicate_extractor.go Show resolved Hide resolved
pkg/planner/core/memtable_predicate_extractor.go Show resolved Hide resolved
pkg/planner/core/memtable_predicate_extractor.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 12, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-12 07:06:27.320623268 +0000 UTC m=+600484.555857374: ☑️ agreed by tangenta.
  • 2024-07-18 07:04:42.082847294 +0000 UTC m=+510304.073788765: ☑️ agreed by GMHDBJD.

@ywqzzy ywqzzy requested a review from hawkingrei July 22, 2024 01:21
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 22, 2024
@hawkingrei
Copy link
Member

/retest

1 similar comment
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jul 22, 2024

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 22, 2024

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow f2d67a7 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit f7fc122 into pingcap:master Jul 22, 2024
22 of 23 checks passed
This was referenced Aug 6, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ywqzzy @hawkingrei @lance6716 @tangenta @GMHDBJD