Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Remove CloneForPlanCache method #54528

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 9, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: Remove CloneForPlanCache method

What changed and how does it work?

planner: Remove CloneForPlanCache method

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/planner SIG: Planner labels Jul 9, 2024
Copy link

tiprow bot commented Jul 9, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/planner/core/plan_cache_rebuild_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 75.89286% with 27 lines in your changes missing coverage. Please review.

Project coverage is 55.9339%. Comparing base (d8098b9) to head (b5cba75).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54528         +/-   ##
=================================================
- Coverage   72.8280%   55.9339%   -16.8941%     
=================================================
  Files          1546       1667        +121     
  Lines        436236     609272     +173036     
=================================================
+ Hits         317702     340790      +23088     
- Misses        98945     245219     +146274     
- Partials      19589      23263       +3674     
Flag Coverage Δ
integration 36.9811% <39.2857%> (?)
unit 71.7469% <75.8928%> (-0.1022%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6308% <ø> (+6.7466%) ⬆️

Copy link

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
Copy link

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 10:31:36.129021408 +0000 UTC m=+353593.364255518: ☑️ agreed by AilinKid.
  • 2024-07-09 14:29:58.239845619 +0000 UTC m=+367895.475079732: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 593c415 into pingcap:master Jul 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants