-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dumpling: check table-list types before dumping (#53683) #54577
dumpling: check table-list types before dumping (#53683) #54577
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54577 +/- ##
================================================
Coverage ? 72.6206%
================================================
Files ? 1412
Lines ? 416745
Branches ? 0
================================================
Hits ? 302643
Misses ? 94143
Partials ? 19959
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, okJiang, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #53683
What problem does this PR solve?
Issue Number: close #53682
Problem Summary:
When users specify
table-list
explicitly, Dumpling will not query the table types.tidb/dumpling/export/dump.go
Lines 1147 to 1150 in 5e5326b
As a result, all tables are considered as
TableTypeBase
and query the meta withSHOW CREATE TABLE
later.If there is a view in
table-list
,SHOW CREATE TABLE
will return the unexpected result:What changed and how does it work?
Query table types even if
table-list
is specified.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.