-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add Vector data type #54635
*: Add Vector data type #54635
Conversation
Signed-off-by: “EricZequan” <[email protected]>
Hi @EricZequan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
/ok-to-test |
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vector-search/vector-data-type #54635 +/- ##
==============================================================================
+ Coverage 72.8511% 75.4360% +2.5848%
==============================================================================
Files 1558 1561 +3
Lines 438406 439440 +1034
==============================================================================
+ Hits 319384 331496 +12112
+ Misses 99322 87406 -11916
- Partials 19700 20538 +838
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
case types.ETVectorFloat32: | ||
sig = &builtinCastVectorFloat32AsUnsupportedSig{bf.baseBuiltinFunc} | ||
// sig.setPbCode(tipb.ScalarFuncSig_CastVectorFloat32AsInt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to support these in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. In most cases user is writing a constant vector string so that it is const-folded in the planning stage and does not need cast pushdown in the execution stage.
Signed-off-by: “EricZequan” <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: “EricZequan” <[email protected]>
/retest |
/retest |
return newSig | ||
} | ||
|
||
func (b *builtinCastVectorFloat32AsStringSig) evalString(ctx EvalContext, row chunk.Row) (res string, isNull bool, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to support vecEvalXXX for vector type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Currently it is not implemented though. @EricZequan will find some time to provide a vectorized version for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XuHuaiyu Vectorized version has been merged in cse. I will later merge the changes in this branch.
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, hawkingrei, tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5389de9
into
pingcap:feature/vector-search/vector-data-type
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary: Support Vector data type
What changed and how does it work?
@@GLOBAL.TIDB_ENABLE_VECTOR_TYPE
CREATE TABLE foo(val VECTOR)
Other scalar functions (like vector distances, vector arithmetics) will be added in future PRs.
The VectorFloat32's Datum / Chunk / Memory layouts are identical, as follows:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.