Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix a caught panic and add comment for DDL functions #54685

Merged
merged 8 commits into from
Jul 23, 2024
Merged

ddl: fix a caught panic and add comment for DDL functions #54685

merged 8 commits into from
Jul 23, 2024

Commits on Jul 17, 2024

  1. --wip-- [skip ci]

    @lance6716
    lance6716 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3693a4b View commit details
    Browse the repository at this point in the history

  2. remove a sanity check 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ac5e101 View commit details
    Browse the repository at this point in the history

  3. update some comment 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cd546dd View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. add updateRawArgs return value 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e3fb415 View commit details
    Browse the repository at this point in the history

  2. add one more special case 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    75e2b4f View commit details
    Browse the repository at this point in the history

  3. fix UT 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    53fe2f9 View commit details
    Browse the repository at this point in the history

  4. update comment 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f782a52 View commit details
    Browse the repository at this point in the history

  5. remove a TODO 

    Signed-off-by: lance6716 <[email protected]>
    @lance6716
    lance6716 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8a1c803 View commit details
    Browse the repository at this point in the history