Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix extract correlated column for expand in building phase will panic. #54988

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54983

Problem Summary:

What changed and how does it work?

expand is an operator that will generate additional columns based on what the child outputs, so in the building phase, construct expand's proj exprs is too much earlier until the column pruning logic is done in the logical optimizing phase.

that's means expand.exprs will be nil in the plan building phase if we use it in the time, it will cause panic. For extracting correlated columns logic, we could simply return nil(what the correlated columns it may generate later must exist its child) because expand itself doesn't produce any correlated columns inside.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix extract correlated column for expand in building phase will panic.
优化器:修复在 build 子查询阶段抽取 expand 算子关联列时会 panic

.
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2024
Copy link

tiprow bot commented Jul 29, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.6013%. Comparing base (7cdf918) to head (74be2aa).
Report is 2 commits behind head on master.

Current head 74be2aa differs from pull request most recent head e701a35

Please upload reports for the commit e701a35 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54988        +/-   ##
================================================
- Coverage   72.8407%   72.6013%   -0.2394%     
================================================
  Files          1560       1562         +2     
  Lines        438616     440106      +1490     
================================================
+ Hits         319491     319523        +32     
- Misses        99541     100801      +1260     
- Partials      19584      19782       +198     
Flag Coverage Δ
unit 71.6378% <0.0000%> (-0.2062%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 45.8355% <ø> (-0.0435%) ⬇️

Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 05:28:43.03257501 +0000 UTC m=+160839.312623079: ☑️ agreed by hawkingrei.
  • 2024-07-29 06:09:26.149750073 +0000 UTC m=+163282.429798142: ☑️ agreed by qw4990.

Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit 02cbd14 into pingcap:master Jul 29, 2024
10 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55031.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 29, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 30, 2024
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build rollup plan case index out of range
4 participants