-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: add version checker for store based backup (#54131) #54993
base: release-8.1
Are you sure you want to change the base?
backup: add version checker for store based backup (#54131) #54993
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54993 +/- ##
================================================
Coverage ? 71.1763%
================================================
Files ? 1465
Lines ? 421705
Branches ? 0
================================================
Hits ? 300154
Misses ? 101061
Partials ? 20490
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #54131
What problem does this PR solve?
Issue Number: ref #52534
Problem Summary:
Due to tikv/tikv#17168, the current tikv does not support backup with subranges very well.
So we need a version checker in case of use store based backup running on old version of tikv.(There is no correctness issue, but the performance may not work as expected.)
What changed and how does it work?
Add a version check
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.