Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Fix errors for JSON functions (#53800) #55047

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53800

What problem does this PR solve?

Issue Number: close #53799

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The errors for incorrect arguments to various JSON functions have been corrected.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 30, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@31fb9de). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #55047   +/-   ##
================================================
  Coverage               ?   72.3433%           
================================================
  Files                  ?       1465           
  Lines                  ?     432756           
  Branches               ?          0           
================================================
  Hits                   ?     313070           
  Misses                 ?      99248           
  Partials               ?      20438           
Flag Coverage Δ
unit 72.3433% <37.5000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 57.8032% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3177% <0.0000%> (?)

@dveeden dveeden changed the title expression: Fix errors for JSON functions | tidb-test=pr/2339 (#53800) expression: Fix errors for JSON functions | tidb-test=pr/2371 (#53800) Jul 30, 2024
@dveeden
Copy link
Contributor

dveeden commented Jul 30, 2024

/test mysql-test

Copy link

tiprow bot commented Jul 30, 2024

@dveeden: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor

dveeden commented Jul 30, 2024

/retest

1 similar comment
@dveeden
Copy link
Contributor

dveeden commented Jul 30, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024
Copy link

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 02:49:58.767333661 +0000 UTC m=+233928.634432748: ☑️ agreed by xhebox.
  • 2024-08-05 02:55:13.004034856 +0000 UTC m=+234242.871133943: ☑️ agreed by windtalker.

@easonn7
Copy link

easonn7 commented Aug 5, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Aug 5, 2024
Copy link

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, easonn7, qw4990, windtalker, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tangenta tangenta added the priority/P0 The issue has P0 priority. label Aug 5, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 5, 2024

/retitle expression: Fix errors for JSON functions (#53800)

@ti-chi-bot ti-chi-bot bot changed the title expression: Fix errors for JSON functions | tidb-test=pr/2371 (#53800) expression: Fix errors for JSON functions (#53800) Aug 5, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 5, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit d4e936e into pingcap:release-8.1 Aug 5, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-53800-to-release-8.1 branch August 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. priority/P0 The issue has P0 priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants