Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add test for same table name in two schemas #55222

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 6, 2024

What problem does this PR solve?

Issue Number: close #55221

Problem Summary:

What changed and how does it work?

  • Check if table ID is consistent after getting from schema.
  • Add a test for the issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Aug 6, 2024
Copy link

tiprow bot commented Aug 6, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.7290%. Comparing base (3dfa15c) to head (db36a7b).

Current head db36a7b differs from pull request most recent head 8e5e65e

Please upload reports for the commit 8e5e65e to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55222        +/-   ##
================================================
+ Coverage   72.8275%   74.7290%   +1.9015%     
================================================
  Files          1570       1570                
  Lines        439518     439584        +66     
================================================
+ Hits         320090     328497      +8407     
+ Misses        99693      90910      -8783     
- Partials      19735      20177       +442     
Flag Coverage Δ
integration 49.0987% <60.0000%> (?)
unit 71.7120% <73.3333%> (-0.1531%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4853% <ø> (+6.6232%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 09:06:15.059161712 +0000 UTC m=+342904.926260801: ☑️ agreed by tiancaiamao.
  • 2024-08-07 03:57:38.459690295 +0000 UTC m=+410788.326789377: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 165ef9d into pingcap:master Aug 7, 2024
10 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

information_schema.tables return wrong result
3 participants