*: update extractor for tidb_index_usage and columns table

[joechenrh]

What problem does this PR solve?

Issue Number: ref #50305

Problem Summary:

What changed and how does it work?

Like #55144, this PR adds InfoSchemaTableNameExtractor to extract schemas, tables and like operators from predicates, and embed it into following extractors:

• InfoSchemaIndexesExtractor, which is used for infoschema.TableTiDBIndexUsage
• ColumnsTableExtractor, which is used for infoschema.TableColumns

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Create about 20w tables

mysql> select count(*) from information_schema.tables where table_schema = "test";
+----------+
| count(*) |
+----------+
|   202823 |
+----------+

Before and after:

mysql> select table_name, column_name from information_schema.columns where table_name = "t10000";
+------------+-------------+
| table_name | column_name |
+------------+-------------+
| t10000     | id          |
| t10000     | col1        |
| t10000     | col2        |
+------------+-------------+
3 rows in set (5.65 sec)

mysql> select table_name, column_name from information_schema.columns where table_name = "t10000";
+------------+-------------+
| table_name | column_name |
+------------+-------------+
| t10000     | id          |
| t10000     | col1        |
| t10000     | col2        |
+------------+-------------+
3 rows in set (0.00 sec)

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[joechenrh]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 86.69528% with 31 lines in your changes missing coverage. Please review.

Project coverage is 74.7655%. Comparing base (7e9f853) to head (cf0931c).
Report is 10 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55263        +/-   ##
================================================
+ Coverage   72.9185%   74.7655%   +1.8470%     
================================================
  Files          1576       1576                
  Lines        440552     440707       +155     
================================================
+ Hits         321244     329497      +8253     
+ Misses        99560      90975      -8585     
- Partials      19748      20235       +487     

Flag	Coverage Δ
integration	49.1426% <80.2575%> (?)
unit	71.8571% <86.6952%> (-0.1170%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.4461% <ø> (+6.5974%)	⬆️

[D3Hunter]

What changed and how does it work?

please add more detail on what you have done. and why you do that, if it's for optimize, what's test result?

[tiancaiamao]

Does it support the index_name filter?

[tiancaiamao]

select ... from index_usage where table_schema = 'xxx' and index_name = 'yyy'

[joechenrh]

Yes, it does.

[tiancaiamao]

I see, it's inside the ListIndexes() function.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-13 07:52:52.847522933 +0000 UTC m=+254457.550992576: ☑️ agreed by tangenta.
• 2024-08-14 01:18:40.927626606 +0000 UTC m=+317205.631096265: ☑️ agreed by tiancaiamao.

[AilinKid]

should we move ord++ to L890, and let it increase the same pace with appending columns, otherwise, your ord and columns are not with the same length (max ord != len(columns)-1)?

[joechenrh]

Ord is the ordinal positions of columns in tables, so it should increase for every non hidden column. Here is the logic before the modification:

tidb/pkg/executor/infoschema_reader.go

Lines 982 to 988 in 0e47f9a

	i := 0
	ForColumnsTag:
	for _, col := range tbl.Columns {
	if col.Hidden {
	continue
	}
	i++

[AilinKid]

i can get your code block, is this (max ord != len(columns)-1)? reasonable ?

[tangenta]

@AilinKid Yes.

ORDINAL_POSITION

The position of the column within the table. ORDINAL_POSITION is necessary because you might want to say ORDER BY ORDINAL_POSITION

[joechenrh]

Yes, since predicates may filter out some columns. And this value is the original position in the table.

[AilinKid]

soga, okok

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,tangenta,tiancaiamao]
• pkg/planner/OWNERS [AilinKid]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment