Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: Support VECTOR for RowFormatv1 #55356

Conversation

EricZequan
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

When CSV data is loaded via LOAD DATA statement, it turns out that row is encoded using Format v1:

LOAD DATA LOCAL INFILE '/Users/breezewish/Downloads/backup_llama_index_rag_test/test.llama_index_rag_test.0000000010000.csv' INTO TABLE `llama_index_rag_test` FIELDS TERMINATED BY ',' ENCLOSED BY '"' LINES TERMINATED BY '\r\n' IGNORE 1 LINES;

And it causes problems:

mysql> select * from llama_index_rag_test limit 10;
ERROR 1105 (HY000): invalid data type: unsupported data type `20`

This PR make it work.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
Copy link

tiprow bot commented Aug 12, 2024

Hi @EricZequan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/vector-search/vector-data-type@d23e795). Learn more about missing BASE report.

Additional details and impacted files
@@                             Coverage Diff                             @@
##             feature/vector-search/vector-data-type     #55356   +/-   ##
===========================================================================
  Coverage                                          ?   74.6876%           
===========================================================================
  Files                                             ?       1561           
  Lines                                             ?     440089           
  Branches                                          ?          0           
===========================================================================
  Hits                                              ?     328692           
  Misses                                            ?      91163           
  Partials                                          ?      20234           
Flag Coverage Δ
integration 49.2671% <0.0000%> (?)
unit 71.7231% <71.4285%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5088% <0.0000%> (?)

@breezewish
Copy link
Member

CI failed, please fix CI first

Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
@EricZequan
Copy link
Contributor Author

CI failed, please fix CI first

CI has passed.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
@breezewish
Copy link
Member

Good job!

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 13, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 13, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [breezewish,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 13:38:49.606024758 +0000 UTC m=+188814.309494401: ☑️ agreed by breezewish.
  • 2024-08-13 03:35:47.083799184 +0000 UTC m=+239031.787268827: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 26124cc into pingcap:feature/vector-search/vector-data-type Aug 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants