-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: Support VECTOR for RowFormatv1 #55356
copr: Support VECTOR for RowFormatv1 #55356
Conversation
Hi @EricZequan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vector-search/vector-data-type #55356 +/- ##
===========================================================================
Coverage ? 74.6876%
===========================================================================
Files ? 1561
Lines ? 440089
Branches ? 0
===========================================================================
Hits ? 328692
Misses ? 91163
Partials ? 20234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CI failed, please fix CI first |
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
e17267c
to
7aef7d7
Compare
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
CI has passed. |
Good job! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
26124cc
into
pingcap:feature/vector-search/vector-data-type
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary:
What changed and how does it work?
When CSV data is loaded via LOAD DATA statement, it turns out that row is encoded using Format v1:
And it causes problems:
This PR make it work.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.