-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Truncate long strings in EXPLAIN #55412
expression: Truncate long strings in EXPLAIN #55412
Conversation
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
Signed-off-by: “EricZequan” <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @EricZequan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vector-search/vector-data-type #55412 +/- ##
===========================================================================
Coverage ? 74.4089%
===========================================================================
Files ? 1561
Lines ? 440170
Branches ? 0
===========================================================================
Hits ? 327526
Misses ? 92369
Partials ? 20275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@EricZequan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Close for #55934 |
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary:
When used with prepared statement, there will be a CAST(String, Vector) in the plan. Previously, we did not correctly truncate long strings. This result in very large slow log when there are vector queries.
What changed and how does it work?
Truncate long strings, so that in vector query scenarios logs will not bloat too much.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.