executor: fix query hang when sorted column is constant #55418
Conversation
ti-chi-bot
bot
added
release-note
|
Hi @xzhangxian1008. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @hawkingrei @wshwsh12 |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55418 +/- ##
================================================
+ Coverage 72.8661% 74.9805% +2.1144%
================================================
Files 1576 1579 +3
Lines 440781 445642 +4861
================================================
+ Hits 321180 334145 +12965
+ Misses 99838 91150 -8688
- Partials 19763 20347 +584
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/cc @windtalker |
| switch col := by.Expr.(type) { | ||
| case *expression.Column: | ||
| e.keyColumns = append(e.keyColumns, col.Index) | ||
| case *expression.Constant: |
There was a problem hiding this comment.
add some comment here to explain why constant don't need to add to keyColumns
There was a problem hiding this comment.
add some comment here to explain why constant don't need to add to keyColumns
done
| // Should not be panic | ||
| tk.MustQuery("SELECT t0.c0 FROM t0 WHERE 0 ORDER BY -646041453 ASC;") | ||
|
|
||
| tk.MustExec("delete from mysql.opt_rule_blacklist;") |
There was a problem hiding this comment.
should only delete predicate_pushd_down and column_prune
There was a problem hiding this comment.
should only delete
predicate_pushd_downandcolumn_prune
done
|
/cc @windtalker |
|
/cc @windtalker |
ti-chi-bot
bot
added
size/L
|
/cc @windtalker |
|
/cc @windtalker |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #55344
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.