table: Add GetExchangePartitionDMLSupport and remove GetDomainInfoSchema in MutateContext

[lcwangchao]

What problem does this PR solve?

Issue Number: ref #53388

Problem Summary:

MutateContext.GetDomainInfoSchema() is only used by DML when a DDL exchanging partition is in progress. It is not required in other cases, such as lighting or DDL reorg (adding index). We can make GetDomainInfoSchema "optional" so to make easier to construct MutateContext for the scenes who does not need it.

What changed and how does it work?

• Remove GetDomainInfoSchema in MutateContext
• Add a new interface ExchangePartitionDMLSupport to provide information schema optionally:

// ExchangePartitionDMLSupport is used for DML operations when the table exchanging a partition.
type ExchangePartitionDMLSupport interface {
	// GetInfoSchemaToCheckExchangeConstraint is used by DML to get the exchanged table to check
	// constraints when exchanging partition.
	GetInfoSchemaToCheckExchangeConstraint() infoschema.MetaOnlyInfoSchema
}

type MutateContext interface {
	// ...
	// GetExchangePartitionDMLSupport returns a `ExchangePartitionDMLSupport` if the context supports it.
	// ExchangePartitionDMLSupport is used by DMLs when the table is exchanging a partition.
	GetExchangePartitionDMLSupport() (ExchangePartitionDMLSupport, bool)
}

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.3299%. Comparing base (1b172b6) to head (c260fe1).
Report is 26 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55435        +/-   ##
================================================
+ Coverage   73.0060%   75.3299%   +2.3239%     
================================================
  Files          1576       1579         +3     
  Lines        440772     445244      +4472     
================================================
+ Hits         321790     335402     +13612     
+ Misses        99280      89771      -9509     
- Partials      19702      20071       +369     

Flag	Coverage Δ
integration	49.8654% <0.0000%> (?)
unit	72.4708% <83.3333%> (+0.3763%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5763% <ø> (+6.5624%)	⬆️

[YangKeao]

LGTM

[mjonss]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-16 06:00:11.0392011 +0000 UTC m=+506895.742670743: ☑️ agreed by YangKeao.
• 2024-08-19 08:32:52.872239026 +0000 UTC m=+167968.006689146: ☑️ agreed by mjonss.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,mjonss,tangenta]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.