*: use model.CIStr in infoschema v2 to handle case insensitive #55450
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
|
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55450 +/- ##
================================================
+ Coverage 75.0073% 75.6080% +0.6006%
================================================
Files 1576 1577 +1
Lines 365712 441252 +75540
================================================
+ Hits 274311 333622 +59311
- Misses 71705 87107 +15402
- Partials 19696 20523 +827
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -954,9 +954,9 @@ func (b *Builder) createSchemaTablesForDB(di *model.DBInfo, tableFromMeta tableF | |||
| if b.enableV2 { | |||
| for name, id := range di.TableName2ID { | |||
There was a problem hiding this comment.
I checked the assignment of di.TableName2ID, the value comes from meta.GetAllNameToIDAndTheMustLoadedTableInfo. And in that function the table name is matched by L: regexp. Should we match for O: instead? Otherwise tableName: model.NewCIStr(name), is still always lowercased
There was a problem hiding this comment.
Good point. We should change to O: match
|
/test unit-test |
|
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
ti-chi-bot
bot
removed
the
needs-rebase
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
What problem does this PR solve?
Issue Number: close #55421
Problem Summary:
What changed and how does it work?
Use model.CIStr in infoschema v2.
Currently, most of the code use case insensitive to compare to string, and use original string for display.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.