planner/core: pushdown TiFlash store type check to ColumnToProto

[joechenrh]

What problem does this PR solve?

Issue Number: close #55462

What changed and how does it work?

As described in #55462, the infoschema checker has found inconsistent with v1 and v2 in TestDisaggregatedTiFlashGeneratedColumn, thus throw a panic.

This is because the column info returned from getOriginalPhysicalTableScan is modifed here:

tidb/pkg/planner/core/find_best_task.go

Lines 2461 to 2467 in f73e3e3

	if ts.StoreType == kv.TiFlash {
	for _, col := range ts.Columns {
	if col.IsVirtualGenerated() {
	col.AddFlag(mysql.GeneratedColumnFlag)
	}
	}
	}

As described in the comments, we should do this check in ColumnToProto to avoid ColumnInfo changes.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7948%. Comparing base (2045418) to head (d95c69e).
Report is 24 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55463        +/-   ##
================================================
+ Coverage   73.0142%   75.7948%   +2.7805%     
================================================
  Files          1576       1577         +1     
  Lines        440774     442138      +1364     
================================================
+ Hits         321828     335118     +13290     
+ Misses        99264      86489     -12775     
- Partials      19682      20531       +849     

Flag	Coverage Δ
integration	50.8466% <72.2222%> (?)
unit	71.9321% <94.4444%> (-0.1649%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	63.1215% <ø> (+17.1243%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-19 07:55:07.459631219 +0000 UTC m=+165702.594081340: ☑️ agreed by wjhuang2016.
• 2024-08-19 07:56:07.478575828 +0000 UTC m=+165762.613025945: ☑️ agreed by fzzf678.

[fzzf678]

/retest-required

[ti-chi-bot]

@fzzf678: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-br-integration-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test canary-notify-when-compatibility-sections-changed
• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fzzf678]

/ok-to-test

[AilinKid]

/test check-dev2

[tiprow]

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[winoros]

/hold

[winoros]

 if ts.StoreType == kv.TiFlash { 
 	for _, col := range ts.Columns { 
 		if col.IsVirtualGenerated() { 
 			col.AddFlag(mysql.GeneratedColumnFlag) 
 		} 
 	} 
 } 

This flag is the one only used in the execution phase and especially the MPP phase.
So we can move it to the phase converting plan to pb. Instead of adding a Clone method that affects all SQLs.\

And, changing ColumnInfo during plan phase is a dangerous operation. Don't do it.

[winoros]

// ColumnToProto converts model.ColumnInfo to tipb.ColumnInfo.
func ColumnToProto(c *model.ColumnInfo, forIndex bool) *tipb.ColumnInfo {
	pc := &tipb.ColumnInfo{
		ColumnId:  c.ID,
		Collation: collate.RewriteNewCollationIDIfNeeded(int32(mysql.CollationNames[c.GetCollate()])),
		ColumnLen: int32(c.GetFlen()),
		Decimal:   int32(c.GetDecimal()),
		Flag:      int32(c.GetFlag()),
		Elems:     c.GetElems(),
	}
	if forIndex {
		// Use array type for read the multi-valued index.
		pc.Tp = int32(c.FieldType.ArrayType().GetType())
		if c.FieldType.IsArray() {
			// Use "binary" collation for read the multi-valued index. Most of the time, the `Collation` of this hidden
			// column should already been set to "binary". However, in old versions, the collation is set to the default
			// value. See https://github.com/pingcap/tidb/issues/46717
			pc.Collation = int32(mysql.CollationNames["binary"])
		}
	} else {
		pc.Tp = int32(c.GetType())
	}
	return pc
}

You can do the same thing as the forIndex. You don't need to clone the model.ColumnInfo, you just need to fix it for the tipb.ColumnInfo.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, CbcWestwolf, fzzf678, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,CbcWestwolf,wjhuang2016]
• pkg/ddl/OWNERS [wjhuang2016]
• pkg/planner/OWNERS [AilinKid]
• pkg/table/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[winoros]

/unhold