Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: expression.BuildSimpleExpr supports to build ParamMarker #55493

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #55492

Problem Summary:

After #53534 , we have removed inner SessionVars in ParamMarker. We can make expression.BuildSimpleExpr to support ParamMarker now

What changed and how does it work?

expression.BuildSimpleExpr supports to build ParamMarker

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2024
Copy link

tiprow bot commented Aug 19, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao lcwangchao force-pushed the parammarkerbuild branch 2 times, most recently from 8483f86 to cd33aef Compare August 19, 2024 07:34
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.8693%. Comparing base (60b96b4) to head (d566a30).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55493        +/-   ##
================================================
- Coverage   74.9997%   74.8693%   -0.1304%     
================================================
  Files          1576       1577         +1     
  Lines        365712     441151     +75439     
================================================
+ Hits         274283     330287     +56004     
- Misses        71724      90674     +18950     
- Partials      19705      20190       +485     
Flag Coverage Δ
integration 49.2580% <80.0000%> (?)
unit 71.9443% <80.0000%> (-2.0522%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 52.6729% <ø> (+4.8465%) ⬆️

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 19, 2024
Copy link

ti-chi-bot bot commented Aug 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-19 08:16:06.322166049 +0000 UTC m=+166961.456616171: ☑️ agreed by YangKeao.
  • 2024-08-19 08:18:25.648732254 +0000 UTC m=+167100.783182390: ☑️ agreed by qw4990.

Copy link

ti-chi-bot bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 509d1bd into pingcap:master Aug 19, 2024
23 checks passed
@lcwangchao lcwangchao deleted the parammarkerbuild branch August 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expression.ParseSimpleExpr should support to build param marker
4 participants