-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: expression.BuildSimpleExpr
supports to build ParamMarker
#55493
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8483f86
to
cd33aef
Compare
cd33aef
to
d566a30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55493 +/- ##
================================================
- Coverage 74.9997% 74.8693% -0.1304%
================================================
Files 1576 1577 +1
Lines 365712 441151 +75439
================================================
+ Hits 274283 330287 +56004
- Misses 71724 90674 +18950
- Partials 19705 20190 +485
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55492
Problem Summary:
After #53534 , we have removed inner
SessionVars
inParamMarker
. We can makeexpression.BuildSimpleExpr
to supportParamMarker
nowWhat changed and how does it work?
expression.BuildSimpleExpr
supports to buildParamMarker
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.