server: wait for auto commit queries before shutdown #55494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
do-not-merge/needs-tests-checked
release-note-none
YangKeao
force-pushed
the
wait-auto-commit-queries
branch
from
004d40e
to
c444908
Compare
YangKeao
force-pushed
the
wait-auto-commit-queries
branch
from
c444908
to
ae5bba8
Compare
ti-chi-bot
bot
added
the
do-not-merge/hold
YangKeao
force-pushed
the
wait-auto-commit-queries
branch
from
ae5bba8
to
1836973
Compare
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
wait-auto-commit-queries
branch
from
1836973
to
cde8fe4
Compare
Defined2014
approved these changes
Aug 19, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/hold Testing now. It seems that it cannot fix the issue in my scenario. |
ti-chi-bot
bot
added
the
do-not-merge/hold
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55494 +/- ##
================================================
+ Coverage 73.0142% 74.9624% +1.9481%
================================================
Files 1576 1577 +1
Lines 440774 441528 +754
================================================
+ Hits 321828 330980 +9152
+ Misses 99264 90373 -8891
- Partials 19682 20175 +493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
13 tasks
|
/unhold No problem. I made some mistakes while testing. |
ti-chi-bot
bot
removed
the
do-not-merge/hold
xhebox
approved these changes
Aug 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #55464
Problem Summary:
Previously, TiDB will not wait for auto-commit queries. These queries are directly killed. It'd be better to wait for them to finish.
What changed and how does it work?
Also checking the connection status when filtering the connection to wait.
Check List
Tests
Run a workload with heavy auto-commit traffic, and you'll see the connections are closed with little leaked lock.
Release note