-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add canonical hasher to take in primitive type directly for hashing. #55570
Conversation
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55570 +/- ##
================================================
+ Coverage 72.9575% 75.0005% +2.0429%
================================================
Files 1577 1581 +4
Lines 440885 450258 +9373
================================================
+ Hits 321659 337696 +16037
+ Misses 99480 92132 -7348
- Partials 19746 20430 +684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
/ok-to-test |
Signed-off-by: AilinKid <[email protected]>
/retest-required |
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.