Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external: range job keys and region split keys are 2 concepts (part 1) #55659

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 26, 2024

What problem does this PR solve?

Issue Number: ref #55374

Problem Summary:

What changed and how does it work?

This is the first part of making job range keys and region split keys 2 different concetps, and it's only related to external engine changing. In next PR I'll change how lighting local backend will use them.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-cherry-pick-release-8.3 size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 26, 2024
Copy link

tiprow bot commented Aug 26, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <[email protected]>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.0108%. Comparing base (f88409a) to head (40da059).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55659         +/-   ##
=================================================
- Coverage   72.8295%   57.0108%   -15.8188%     
=================================================
  Files          1583       1735        +152     
  Lines        443003     623203     +180200     
=================================================
+ Hits         322637     355293      +32656     
- Misses       100561     243260     +142699     
- Partials      19805      24650       +4845     
Flag Coverage Δ
integration 39.4772% <71.8750%> (?)
unit 71.9592% <61.4583%> (-0.0016%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3402% <ø> (+16.8854%) ⬆️

@lance6716 lance6716 changed the title [WIP]external: range job keys and region split keys are 2 concepts external: range job keys and region split keys are 2 concepts (part 1) Aug 27, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
pkg/disttask/importinto/task_executor.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 30, 2024
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 30, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
Copy link

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 00:48:00.938490367 +0000 UTC m=+1090476.072940488: ☑️ agreed by D3Hunter.
  • 2024-08-30 04:03:48.188229425 +0000 UTC m=+1102223.322679546: ☑️ agreed by GMHDBJD.

Copy link

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 30, 2024
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 30, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 30, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit c65692b into pingcap:master Aug 30, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #55781.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.3 release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants