Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: use ListTablesWithSpecialAttribute instead of SchemaTableInfos #55686

Merged

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Aug 27, 2024

What problem does this PR solve?

Issue Number: ref #55394

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
  1. create a cluster with 3 tiflash nodes by tiup playground --db.binpath bin/tidb-server --db 1 --pd 1 --kv 1 --tiflash 3
  2. create two tables with tiflash replica 1 and 3
TiDB root@127.0.0.1:(none)> use test;
You are now connected to database "test" as user "root"
Time: 0.000s
TiDB root@127.0.0.1:test> create table t1 (c int);
Query OK, 0 rows affected
Time: 0.021s
TiDB root@127.0.0.1:test> create table t2 (c int);
Query OK, 0 rows affected
Time: 0.026s
TiDB root@127.0.0.1:test> alter table t1 set tiflash replica 1;
Query OK, 0 rows affected
Time: 0.023s
TiDB root@127.0.0.1:test> alter table t2 set tiflash replica 3;
Query OK, 0 rows affected
Time: 0.028s
  1. curl http://127.0.0.1:10080/tiflash/replica-deprecated
[
 {
  "id": 106,
  "replica_count": 3,
  "location_labels": [],
  "available": true,
  "high_priority": false
 },
 {
  "id": 104,
  "replica_count": 1,
  "location_labels": [],
  "available": true,
  "high_priority": false
 }
]%

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
@CbcWestwolf CbcWestwolf changed the title infoschema: use ListTablesWithSpecialAttribute instead of SchemaTables infoschema: use ListTablesWithSpecialAttribute instead of SchemaTableInfos Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9029%. Comparing base (290dc46) to head (8d084bf).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55686        +/-   ##
================================================
+ Coverage   72.9295%   74.9029%   +1.9733%     
================================================
  Files          1581       1582         +1     
  Lines        442365     443510      +1145     
================================================
+ Hits         322615     332202      +9587     
+ Misses        99938      91099      -8839     
- Partials      19812      20209       +397     
Flag Coverage Δ
integration 49.0880% <0.0000%> (?)
unit 71.9979% <100.0000%> (-0.0022%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3220% <ø> (+6.8671%) ⬆️

@CbcWestwolf
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Aug 27, 2024

@CbcWestwolf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 62a692e link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, joccau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 09:42:36.019184356 +0000 UTC m=+863351.153634475: ☑️ agreed by fzzf678.
  • 2024-08-29 02:54:49.300514086 +0000 UTC m=+1011684.434964207: ☑️ agreed by joccau.

@CbcWestwolf CbcWestwolf merged commit 47ca7be into pingcap:master Aug 29, 2024
23 checks passed
@CbcWestwolf CbcWestwolf deleted the ListTablesWithSpecialAttribute branch August 29, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants