-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema_v2: replace SchemaTableInfos in fetchShowStatsExtended
#55687
infoschema_v2: replace SchemaTableInfos in fetchShowStatsExtended
#55687
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55687 +/- ##
================================================
+ Coverage 72.9295% 74.7859% +1.8563%
================================================
Files 1581 1582 +1
Lines 442365 442666 +301
================================================
+ Hits 322615 331052 +8437
+ Misses 99938 91341 -8597
- Partials 19812 20273 +461
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
for _, tblInfo := range tables { | ||
pi := tblInfo.GetPartitionInfo() | ||
// Extended statistics for partitioned table is not supported now. | ||
if pi != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exclude partition table after get all table infos
} | ||
|
||
for _, db := range is.AllSchemaNames() { | ||
simpleTblInfos, err := is.SchemaSimpleTableInfos(ctx, db) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get simple table infos,then exclude partition tables,and then get tableInfo one by one
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #55394
Problem Summary:
What changed and how does it work?
In
fetchShowStatsExtended
, we traverse all dbs to find tables with partition and pass them toappendTableForStatsExtended
. Now, the process of traversal can be replace byListTablesWithSpecialAttribute
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.