planner: introduce hashEquals for expression.Column/collationInfo/fieldType #55691

AilinKid · 2024-08-27T08:47:00Z

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: arenatlx <[email protected]>

tiprow · 2024-08-27T08:47:39Z

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/parser/types/field_type.go

Signed-off-by: arenatlx <[email protected]>

pkg/expression/column.go

codecov · 2024-08-27T09:19:34Z

Codecov Report

Attention: Patch coverage is 77.23577% with 28 lines in your changes missing coverage. Please review.

Project coverage is 57.1825%. Comparing base (4f85a35) to head (fb10a8e).
Report is 24 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55691         +/-   ##
=================================================
- Coverage   72.8618%   57.1825%   -15.6793%     
=================================================
  Files          1582       1708        +126     
  Lines        442708     624421     +181713     
=================================================
+ Hits         322565     357060      +34495     
- Misses       100322     243734     +143412     
- Partials      19821      23627       +3806

Flag	Coverage Δ
integration	`38.3065% <0.0000%> (?)`
unit	`73.0175% <77.2357%> (+1.0343%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`52.1995% <ø> (+6.7615%)`	⬆️

AilinKid · 2024-08-28T07:18:14Z

/test unit-test

tiprow · 2024-08-28T07:18:35Z

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: arenatlx <[email protected]>

tangenta · 2024-08-29T05:39:18Z

pkg/parser/types/field_type.go

+}
+
+// Equals implements the cascades/base.Hasher.<1th> interface.
+func (ft *FieldType) Equals(other any) bool {


This pattern is weird, why not define the signature as Equals(other *FieldType)?

its same for type downcast

say logicalProjection has one children stored as [child:logicalPlan]
when we want to check whether proj.child is equal to the other, we need to switch case to tell what it's children actual type is.

switch x := proj.child(type) { case: logicalSelection: y, ok := other.(logicalSelection) if !ok { return false } return x.Equals(other) case ... }

the type check is unavoidable, it depends on how you are ganna implement it, inside Equals or outside of it

ti-chi-bot · 2024-08-29T06:25:21Z

[LGTM Timeline notifier]

Timeline:

2024-08-29 05:07:49.331355342 +0000 UTC m=+1019664.465805463: ☑️ agreed by hawkingrei.
2024-08-29 06:25:20.601393941 +0000 UTC m=+1024315.735844165: ☑️ agreed by tangenta.

windtalker · 2024-08-29T08:39:18Z

pkg/parser/types/field_type.go

+		return false
+	}
+	for i, one := range ft.elems {
+		if one != ft2.elems[i] {


do we need to consider collation here?

no, Equals is called for double check after hash64 is the same for two obj. The semantic here should directly check whether this two ft are exactly the same, from the raw string is enough, "a" = "A" is not in consideration, otherwise, hash64 value won't be same if though

But if you update the hash64 method to consider the collation, it is possible that under ci collation, two types with "a" and "A" are equal and have the same hash64. So the problem is, by you original definition and purpose, should we define enum type("a","b") equals to enum type("A","B") when collation is ci?

“by you original definition and purpose, should we define enum type("a","b") equals to enum type("A","B") when collation is ci?”
this is not in consideration here, high-level equivalence is guaranteed by datum-compare liked infra, hash64 is based from the basic representation of data structure.

windtalker

lgtm

ti-chi-bot · 2024-09-02T03:31:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/expression/OWNERS~~ [windtalker]
~~pkg/parser/OWNERS~~ [tangenta]
~~pkg/planner/OWNERS~~ [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AilinKid · 2024-09-02T05:03:01Z

/retest-required

tiprow · 2024-09-02T05:03:23Z

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-09-02T05:40:25Z

/retest

AilinKid · 2024-09-02T06:05:30Z

/retest-required

tiprow · 2024-09-02T06:05:53Z

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid · 2024-09-02T06:13:16Z

/ok-to-test

AilinKid · 2024-09-02T06:47:00Z

/test pull-mysql-client-test

tiprow · 2024-09-02T06:47:22Z

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid · 2024-09-02T06:55:02Z

/retest check-dev

ti-chi-bot · 2024-09-02T06:55:05Z

@AilinKid: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/retest check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AilinKid · 2024-09-02T06:55:15Z

/test check-dev

tiprow · 2024-09-02T06:55:24Z

@AilinKid: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/retest check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-09-02T06:55:36Z

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

.

8f6b79f

Signed-off-by: arenatlx <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 27, 2024

AilinKid mentioned this pull request Aug 27, 2024

TopDown optimizing approach exploring and implementation based on cascades/columbia #51664

Open

AilinKid commented Aug 27, 2024

View reviewed changes

pkg/parser/types/field_type.go Show resolved Hide resolved

AilinKid added 2 commits August 27, 2024 16:57

.

77b91b4

Signed-off-by: arenatlx <[email protected]>

.

9cf36f0

Signed-off-by: arenatlx <[email protected]>

hawkingrei reviewed Aug 27, 2024

View reviewed changes

pkg/expression/column.go Show resolved Hide resolved

.

46e9f04

Signed-off-by: arenatlx <[email protected]>

ti-chi-bot bot added the sig/planner SIG: Planner label Aug 28, 2024

.

fb10a8e

Signed-off-by: arenatlx <[email protected]>

hawkingrei approved these changes Aug 29, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 29, 2024

tangenta reviewed Aug 29, 2024

View reviewed changes

tangenta approved these changes Aug 29, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2024

windtalker reviewed Aug 29, 2024

View reviewed changes

windtalker approved these changes Sep 2, 2024

View reviewed changes

ti-chi-bot bot added the approved label Sep 2, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 2, 2024

ti-chi-bot bot merged commit dd114f1 into pingcap:master Sep 2, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: introduce hashEquals for expression.Column/collationInfo/fieldType #55691

planner: introduce hashEquals for expression.Column/collationInfo/fieldType #55691

AilinKid commented Aug 27, 2024

tiprow bot commented Aug 27, 2024

codecov bot commented Aug 27, 2024 •

edited

Loading

AilinKid commented Aug 28, 2024

tiprow bot commented Aug 28, 2024

tangenta Aug 29, 2024

AilinKid Aug 29, 2024 •

edited

Loading

ti-chi-bot bot commented Aug 29, 2024

windtalker Aug 29, 2024

AilinKid Aug 29, 2024

windtalker Aug 29, 2024 •

edited

Loading

AilinKid Sep 2, 2024

windtalker left a comment

ti-chi-bot bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

hawkingrei commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

ti-chi-bot bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

planner: introduce hashEquals for expression.Column/collationInfo/fieldType #55691

planner: introduce hashEquals for expression.Column/collationInfo/fieldType #55691

Conversation

AilinKid commented Aug 27, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Aug 27, 2024

codecov bot commented Aug 27, 2024 • edited Loading

Codecov Report

AilinKid commented Aug 28, 2024

tiprow bot commented Aug 28, 2024

tangenta Aug 29, 2024

Choose a reason for hiding this comment

AilinKid Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

ti-chi-bot bot commented Aug 29, 2024

[LGTM Timeline notifier]

windtalker Aug 29, 2024

Choose a reason for hiding this comment

AilinKid Aug 29, 2024

Choose a reason for hiding this comment

windtalker Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

AilinKid Sep 2, 2024

Choose a reason for hiding this comment

windtalker left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

hawkingrei commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

ti-chi-bot bot commented Sep 2, 2024

AilinKid commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

tiprow bot commented Sep 2, 2024

codecov bot commented Aug 27, 2024 •

edited

Loading

AilinKid Aug 29, 2024 •

edited

Loading

windtalker Aug 29, 2024 •

edited

Loading