Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix missing update on nested generated column #55829

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Sep 3, 2024

What problem does this PR solve?

Issue Number: close #53967

Problem Summary:
IF:
Virtual generated column B depends on A
Virtual generated column C depends on B
Index idx on C.
Update A should update index idx too.

but the dependence C on B is not built correctly.

What changed and how does it work?

Build dependence correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix missing update on nested generated column

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. sig/planner SIG: Planner needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed labels Sep 3, 2024
@wjhuang2016
Copy link
Member Author

/retest

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.6921%. Comparing base (0583e84) to head (d1f6d98).
Report is 407 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55829         +/-   ##
=================================================
- Coverage   72.7958%   56.6921%   -16.1037%     
=================================================
  Files          1588       1724        +136     
  Lines        443469     629159     +185690     
=================================================
+ Hits         322827     356684      +33857     
- Misses       100772     248655     +147883     
- Partials      19870      23820       +3950     
Flag Coverage Δ
integration 37.7083% <100.0000%> (?)
unit 71.9214% <100.0000%> (+0.0148%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 51.7790% <ø> (+6.3478%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2024
@wjhuang2016
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 09:08:30.788698079 +0000 UTC m=+435435.306751004: ☑️ agreed by tangenta.
  • 2024-09-04 09:47:10.632459642 +0000 UTC m=+437755.150512567: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit b91cb01 into pingcap:master Sep 4, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55852.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55853.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 28, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dml on table contains generated columns report assertion failed error
4 participants