ddl, stat: switch to new struct for add/truncate/drop partition #55893

lance6716 · 2024-09-06T03:30:22Z

What problem does this PR solve?

Issue Number: ref #55723

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <[email protected]>

tiprow · 2024-09-06T03:30:37Z

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-09-06T03:31:25Z

pkg/statistics/handle/ddl/truncate_partition.go

@@ -16,6 +16,7 @@ package ddl

 import (
 	"github.com/pingcap/errors"
+	util2 "github.com/pingcap/tidb/pkg/ddl/util"


Suggested change

util2 "github.com/pingcap/tidb/pkg/ddl/util"

ddlutil "github.com/pingcap/tidb/pkg/ddl/util"

Signed-off-by: lance6716 <[email protected]>

codecov · 2024-09-06T03:53:33Z

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.0831%. Comparing base (181c37a) to head (b8d80ce).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55893         +/-   ##
=================================================
- Coverage   72.8586%   57.0831%   -15.7755%     
=================================================
  Files          1603       1754        +151     
  Lines        445331     630948     +185617     
=================================================
+ Hits         324462     360165      +35703     
- Misses       100869     246049     +145180     
- Partials      20000      24734       +4734

Flag	Coverage Δ
integration	`39.9465% <76.1194%> (?)`
unit	`72.2678% <86.5671%> (+0.2997%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.1899% <ø> (+17.3896%)`	⬆️

lance6716 · 2024-09-06T04:40:40Z

ptal @hawkingrei

Rustin170506

Looks good to me. Thanks! 👍

fzzf678

rest lgtm

fzzf678 · 2024-09-06T06:41:47Z

pkg/ddl/util/schema_change_notifier.go

@@ -101,3 +103,74 @@ func (s *SchemaChangeEvent) GetTruncateTableInfo() (
 	intest.Assert(s.tp == model.ActionTruncateTable)
 	return s.newTableInfo, s.oldTableInfo
 }
+
+// NewAddPartitionEvent creates a SchemaChangeEvent whose type is


The comment seems repeated

I'll remove it in next PR

ti-chi-bot · 2024-09-06T06:43:13Z

[LGTM Timeline notifier]

Timeline:

2024-09-06 06:42:43.563703025 +0000 UTC m=+599488.081755952: ☑️ agreed by Rustin170506.
2024-09-06 06:43:12.04892084 +0000 UTC m=+599516.566973765: ☑️ agreed by fzzf678.

lance6716 · 2024-09-06T06:45:48Z

/approve

ti-chi-bot · 2024-09-06T06:45:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, lance6716, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/ddl/OWNERS~~ [lance6716]
~~pkg/statistics/OWNERS~~ [Rustin170506]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lance6716 · 2024-09-06T07:49:35Z

/retest

tiprow · 2024-09-06T07:49:55Z

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716 · 2024-09-06T08:59:51Z

/retest

tiprow · 2024-09-06T09:00:14Z

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* origin/master: (33 commits) build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762) build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894) planner: fix incorrect estRows with global index and json column (pingcap#55842) ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893) planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918) expression: support tidb encode key function (pingcap#51678) planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732) executor: some code refine of hash join v2 (pingcap#55887) infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847) ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588) planner: move index advisor into the kernel (pingcap#55874) ddl, stats: switch to new struct for create/truncate table (pingcap#55811) executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855) *: Add tidbCPU/tikvCPU into system tables (pingcap#55455) ddl: use static contexts in `NewReorgCopContext` (pingcap#55823) executor: fix index out of range bug in hash join v2 (pingcap#55864) executor: record index usage for the clustered primary keys (pingcap#55602) domain: load all non-public tables into infoschema (pingcap#55142) test: fix unstable TestShowViewPriv (pingcap#55868) ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863) ...

ddl, stat: switch to new struct for add/truncate/drop partition

4ab9f2b

Signed-off-by: lance6716 <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 6, 2024

hawkingrei reviewed Sep 6, 2024

View reviewed changes

lance6716 added 2 commits September 6, 2024 11:32

address comment

3af8a99

Signed-off-by: lance6716 <[email protected]>

fix bazel

b8d80ce

Signed-off-by: lance6716 <[email protected]>

Rustin170506 approved these changes Sep 6, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 6, 2024

fzzf678 approved these changes Sep 6, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2024

ti-chi-bot bot added the approved label Sep 6, 2024

ti-chi-bot bot merged commit 4dc8f3d into pingcap:master Sep 6, 2024
23 of 25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl, stat: switch to new struct for add/truncate/drop partition #55893

ddl, stat: switch to new struct for add/truncate/drop partition #55893

lance6716 commented Sep 6, 2024 •

edited

Loading

tiprow bot commented Sep 6, 2024

hawkingrei Sep 6, 2024

codecov bot commented Sep 6, 2024 •

edited

Loading

lance6716 commented Sep 6, 2024

Rustin170506 left a comment

fzzf678 left a comment

fzzf678 Sep 6, 2024 •

edited

Loading

lance6716 Sep 6, 2024

ti-chi-bot bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024

ti-chi-bot bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024

tiprow bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024

tiprow bot commented Sep 6, 2024

	util2 "github.com/pingcap/tidb/pkg/ddl/util"
	ddlutil "github.com/pingcap/tidb/pkg/ddl/util"

ddl, stat: switch to new struct for add/truncate/drop partition #55893

ddl, stat: switch to new struct for add/truncate/drop partition #55893

Conversation

lance6716 commented Sep 6, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 6, 2024

hawkingrei Sep 6, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 6, 2024 • edited Loading

Codecov Report

lance6716 commented Sep 6, 2024

Rustin170506 left a comment

Choose a reason for hiding this comment

fzzf678 left a comment

Choose a reason for hiding this comment

fzzf678 Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

lance6716 Sep 6, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 6, 2024

[LGTM Timeline notifier]

lance6716 commented Sep 6, 2024

ti-chi-bot bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024

tiprow bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024

tiprow bot commented Sep 6, 2024

lance6716 commented Sep 6, 2024 •

edited

Loading

codecov bot commented Sep 6, 2024 •

edited

Loading

fzzf678 Sep 6, 2024 •

edited

Loading