planner: fix incorrect maintenance of handleColHelper for recursive CTE (#55732)

[ti-chi-bot]

This is an automated cherry-pick of #55732

What problem does this PR solve?

Issue Number: close #55666

Problem Summary:

If the recursive part of a CTE references tables other than the CTE itself, the b.handleHelper won't be correctly cleared during buildRecursiveCTE().

It's because this function relies on an error from buildSelect() or buildSetOpr() to recognize the boundary between the seed part and the recursive part. But b.handleHelper won't be cleared when an error happens.

When this happens, there will be some wrong and redundant entries in b.handleHelper, which makes users of this field like buildDelete() get the wrong result or panic.

What changed and how does it work?

Since this PR needs to be cherry-picked, I can't change too many.

• In buildRecursiveCTE(), clear the b.handleHelper if an error is returned from buildSelect() or buildSetOpr().
• Try to make the b.handleHelper more clear for recursive CTE:
  • Now tryBuildCTE() will always push an entry into handleHelper when successful.
  • Now buildRecursiveCTE() will always push an entry into handleHelper when successful.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[time-and-fate]

/retest

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@5315279). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.1     #55899   +/-   ##
================================================
  Coverage               ?   71.1856%           
================================================
  Files                  ?       1466           
  Lines                  ?     423063           
  Branches               ?          0           
================================================
  Hits                   ?     301160           
  Misses                 ?     101382           
  Partials               ?      20521           

Flag	Coverage Δ
unit	71.1856% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	41.3049% <0.0000%> (?)

[time-and-fate]

/retest

[ti-chi-bot]

@Rustin170506: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rustin170506, time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [time-and-fate,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-06 09:22:54.331153535 +0000 UTC m=+2644.071577489: ☑️ agreed by winoros.
• 2024-09-06 09:57:46.446174361 +0000 UTC m=+4736.186598292: ☑️ agreed by time-and-fate.