Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add maintaining the priority queue in memory design #55903

Merged
merged 15 commits into from
Sep 10, 2024
Merged

docs: Add maintaining the priority queue in memory design #55903

merged 15 commits into from
Sep 10, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Sep 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What changed and how does it work?

rendered

I have added the documentation for maintaining the priority queue in the memory design.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2024
@Rustin170506
fix: add discussion PR linke
60e15e4 
Signed-off-by: Rustin170506 <[email protected]>
@Rustin170506 Rustin170506 added the skip-issue-check Indicates that a PR no need to check linked issue. label Sep 6, 2024
@Rustin170506
fix: better statement
2420246 
Signed-off-by: Rustin170506 <[email protected]>
@Rustin170506 Rustin170506 mentioned this pull request Sep 6, 2024
Open
27 tasks
@Rustin170506 Rustin170506 added the component/ddl This issue is related to DDL of TiDB. label Sep 6, 2024
@Rustin170506
fix: add tracking issue link
e6050d5 
Signed-off-by: Rustin170506 <[email protected]>
lance6716
lance6716 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

docs/design/2024-09-06-maintain-priority-queue-in-memory.md Outdated Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Outdated Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Outdated Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Outdated Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Show resolved Hide resolved
docs/design/2024-09-06-maintain-priority-queue-in-memory.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 09:43:45.98090179 +0000 UTC m=+263095.721325751: ☑️ agreed by lance6716.
  • 2024-09-10 02:56:11.141367483 +0000 UTC m=+325040.881791422: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit a6c83ba into pingcap:master Sep 10, 2024
5 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-pq-in-mem branch September 10, 2024 03:01
Benjamin2037 pushed a commit to Benjamin2037/tidb that referenced this pull request Sep 11, 2024
@Rustin170506 @Benjamin2037
docs: Add maintaining the priority queue in memory design (pingcap#55903
9133786 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
approved component/ddl This issue is related to DDL of TiDB. component/docs component/statistics lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rustin170506 @lance6716 @qw4990