-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix data race in IndexNestedLoopHashJoin
(#55824)
#55911
Merged
ti-chi-bot
merged 4 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-55824-to-release-6.1
Sep 10, 2024
Merged
executor: fix data race in IndexNestedLoopHashJoin
(#55824)
#55911
ti-chi-bot
merged 4 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-55824-to-release-6.1
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
labels
Sep 6, 2024
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
do-not-merge/cherry-pick-not-approved
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Sep 6, 2024
ti-chi-bot
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Sep 6, 2024
XuHuaiyu
approved these changes
Sep 10, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Sep 10, 2024
wshwsh12
approved these changes
Sep 10, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #55824
What problem does this PR solve?
Issue Number: close #49692
Problem Summary:
IndexNestedLoopHashJoin.panicErr
is not thread-safeWhat changed and how does it work?
IndexNestedLoopHashJoin.panicErr
can not be read until it has been initialized.TestIssue49692
to make sure the context done branch can be executed.Check List
Tests
Manual test:
tidb/pkg/executor/join/index_lookup_hash_join.go
Lines 204 to 209 in 4a1a771
tidb/pkg/executor/join/index_lookup_hash_join.go
Lines 302 to 306 in 4a1a771
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.