Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statstics: increase the synchronization offset size when to sync stats #55943

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 9, 2024

What problem does this PR solve?

Issue Number: ref #54552

Problem Summary:

What changed and how does it work?

Let's first increase the synchronization offset size to reduce the likelihood of resynchronization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked labels Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3129%. Comparing base (2d1ed88) to head (b854d34).
Report is 10 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55943         +/-   ##
=================================================
- Coverage   72.8465%   56.3129%   -16.5336%     
=================================================
  Files          1604       1754        +150     
  Lines        445737     629127     +183390     
=================================================
+ Hits         324704     354280      +29576     
- Misses       101006     250422     +149416     
- Partials      20027      24425       +4398     
Flag Coverage Δ
integration 38.5632% <100.0000%> (?)
unit 71.9654% <100.0000%> (+0.0095%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8841% <ø> (+7.1466%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 06:46:41.071256443 +0000 UTC m=+252470.811680374: ☑️ agreed by time-and-fate.
  • 2024-09-09 08:43:27.678259787 +0000 UTC m=+259477.418683727: ☑️ agreed by qw4990.

@hawkingrei hawkingrei changed the title statstics: increase the synchronization offset size when to sync init statstics: increase the synchronization offset size when to sync stats Sep 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit df1c21e into pingcap:master Sep 9, 2024
24 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #55960.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 9, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #55961.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 9, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #55962.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #55963.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants