Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support hash join spill #55950

Merged
merged 65 commits into from
Oct 22, 2024
Merged

executor: support hash join spill #55950

merged 65 commits into from
Oct 22, 2024

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Sep 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #55153

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support spill of hash join v2

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 9, 2024

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @XuHuaiyu

windtalker
windtalker reviewed Sep 11, 2024
View reviewed changes
pkg/executor/join/base_join_probe.go Outdated Show resolved Hide resolved
pkg/executor/join/base_join_probe.go Outdated Show resolved Hide resolved
pkg/executor/join/base_join_probe.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_spill.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Outdated Show resolved Hide resolved
pkg/executor/join/row_table_builder.go Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @XuHuaiyu

windtalker
windtalker reviewed Sep 14, 2024
View reviewed changes
pkg/executor/join/hash_join_v2.go Show resolved Hide resolved
pkg/executor/join/hash_join_v2.go Outdated Show resolved Hide resolved
@tiprow tiprow
Copy link

tiprow bot commented Sep 27, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 8, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Oct 8, 2024 •
edited
Loading

*** Run endless tests again before merged. ***

XuHuaiyu
XuHuaiyu reviewed Oct 10, 2024
View reviewed changes
pkg/executor/join/hash_join_spill.go Show resolved Hide resolved
pkg/executor/join/hash_join_v2.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_v2.go Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@xzhangxian1008
Copy link
Contributor Author

*** Run endless tests again before merged. ***

Uncomment TestIssue20270 before merge

@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

XuHuaiyu
XuHuaiyu reviewed Oct 16, 2024
View reviewed changes
pkg/executor/join/hash_join_v2.go Show resolved Hide resolved
pkg/executor/join/hash_join_spill_helper.go Outdated Show resolved Hide resolved
pkg/executor/join/hash_join_base.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 10:06:14.024771502 +0000 UTC m=+1646843.765195440: ☑️ agreed by windtalker.
  • 2024-10-18 02:26:52.65755566 +0000 UTC m=+583609.806465493: ☑️ agreed by XuHuaiyu.

@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit d34724f into pingcap:master Oct 22, 2024
21 checks passed
@xzhangxian1008 xzhangxian1008 deleted the hash-join-spill-v2 branch October 22, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support hash join spill
3 participants
@xzhangxian1008 @windtalker @XuHuaiyu