Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema_v2: remove schemaTableInfos call of fetchAllTablePlacements #55958

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 9, 2024

What problem does this PR solve?

Issue Number: ref #55394

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
    original show placement test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2024
Copy link

tiprow bot commented Sep 9, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.2593%. Comparing base (499e45f) to head (9d8c3c1).
Report is 127 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55958         +/-   ##
=================================================
- Coverage   72.8489%   59.2593%   -13.5897%     
=================================================
  Files          1604       1786        +182     
  Lines        445733     658549     +212816     
=================================================
+ Hits         324712     390252      +65540     
- Misses       101000     243999     +142999     
- Partials      20021      24298       +4277     
Flag Coverage Δ
integration 41.5302% <0.0000%> (?)
unit 74.3352% <100.0000%> (+2.3739%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.1514% <ø> (+0.1947%) ⬆️
parser ∅ <ø> (∅)
br 63.6297% <ø> (+17.8888%) ⬆️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 10, 2024

/retest

Copy link

tiprow bot commented Sep 10, 2024

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Sep 10, 2024

/retest

Copy link

tiprow bot commented Sep 10, 2024

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 07:43:02.114346465 +0000 UTC m=+1465451.854770405: ☑️ agreed by wjhuang2016.
  • 2024-09-25 05:58:47.404148186 +0000 UTC m=+1631997.144572124: ☑️ agreed by tangenta.

Copy link

tiprow bot commented Sep 25, 2024

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 9d8c3c1 link true /test fast_test_tiprow
tidb_parser_test 9d8c3c1 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 165c4a5 into pingcap:master Sep 25, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants