statistics: reorder key and value generic parameters of the heap #55974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rustin170506 <[email protected]>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: Rustin170506 <[email protected]>
Rustin170506
changed the title
Rustin170506
commented
Sep 10, 2024
AilinKid
approved these changes
Sep 10, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
lance6716
approved these changes
Sep 10, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55974 +/- ##
=================================================
- Coverage 72.8586% 56.4363% -16.4223%
=================================================
Files 1605 1755 +150
Lines 446293 630992 +184699
=================================================
+ Hits 325163 356109 +30946
- Misses 101092 250460 +149368
- Partials 20038 24423 +4385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
Benjamin2037
pushed a commit
to Benjamin2037/tidb
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #55906
Problem Summary:
What changed and how does it work?
Just reorder the generic parameters of the heap. <V,K> -> <K,V>.
When I wrote this code, I thought it didn't matter, but it was kind of annoying when I tried to use it. So it's better to keep it like any other normal heap.
Also, I added
main_testto check the goroutine leak.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.