statistics: add an analysis job factory #56073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56073 +/- ##
=================================================
- Coverage 72.8981% 56.1252% -16.7729%
=================================================
Files 1609 1760 +151
Lines 447275 637736 +190461
=================================================
+ Hits 326055 357931 +31876
- Misses 101140 255024 +153884
- Partials 20080 24781 +4701
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rustin170506
commented
Sep 13, 2024
13 tasks
Rustin170506
changed the title
AilinKid
approved these changes
Sep 13, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
winoros
approved these changes
Sep 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: Rustin170506 <[email protected]> refacor: move to priorityqueue_test Signed-off-by: Rustin170506 <[email protected]> refactor: better time window Signed-off-by: Rustin170506 <[email protected]> refactor: better parition name and id Signed-off-by: Rustin170506 <[email protected]> docs: add comments back Signed-off-by: Rustin170506 <[email protected]> docs: add comments back Signed-off-by: Rustin170506 <[email protected]> docs: add comments back Signed-off-by: Rustin170506 <[email protected]> tests: add more cases Signed-off-by: Rustin170506 <[email protected]> refactor: make lint happy Signed-off-by: Rustin170506 <[email protected]> docs: mark it is not thread safe Signed-off-by: Rustin170506 <[email protected]> refactor: rename Signed-off-by: Rustin170506 <[email protected]> fix Signed-off-by: Rustin170506 <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-job-factory
branch
from
54c666d
to
f251d0b
Compare
|
Conflicts resolved and rebased on the master branch. |
Signed-off-by: Rustin170506 <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #55906
Problem Summary:
What changed and how does it work?
An analysis job factory was added to create different analysis jobs. This would help use to reuse code when we implement the new priority queue.
Check out https://github.com/pingcap/tidb/pull/55889/files#r1758531218 to see how I used it in my new PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.