Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add the SetIndicators API #56248

Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Sep 24, 2024

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

  1. Added the SetIndicators API to update the indicators of jobs.
  2. Added a util function IsDynamicPartitionedTableAnalysisJob to check if the job is a dynamic partitioned table analysis job.

Check https://github.com/pingcap/tidb/pull/55889/files#r1772550852 to see how we use it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Sep 24, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.7826%. Comparing base (ad68216) to head (3a3b6c6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56248        +/-   ##
================================================
+ Coverage   73.4166%   75.7826%   +2.3660%     
================================================
  Files          1601       1623        +22     
  Lines        443902     455079     +11177     
================================================
+ Hits         325898     344871     +18973     
+ Misses        98053      89267      -8786     
- Partials      19951      20941       +990     
Flag Coverage Δ
integration 51.1250% <0.0000%> (?)
unit 72.8371% <33.3333%> (+0.3595%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.9451% <ø> (+7.0555%) ⬆️

Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 requested review from 3AceShowHand and AilinKid and removed request for 3AceShowHand September 24, 2024 06:11
Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 04:06:13.051768738 +0000 UTC m=+1538842.792192688: ☑️ agreed by qw4990.
  • 2024-09-24 07:34:36.290439974 +0000 UTC m=+1551346.030863911: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 05cff08 into pingcap:master Sep 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/statistics lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants