Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add memo test and implement some logical operator's HashEquals. #56250

Merged
merged 10 commits into from
Oct 10, 2024
Merged

planner: add memo test and implement some logical operator's HashEquals. #56250

merged 10 commits into from
Oct 10, 2024

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 24, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 140 lines in your changes missing coverage. Please review.

Project coverage is 75.4817%. Comparing base (9b1fa1c) to head (3c7fcf8).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56250        +/-   ##
================================================
+ Coverage   73.4078%   75.4817%   +2.0738%     
================================================
  Files          1626       1626                
  Lines        449038     449391       +353     
================================================
+ Hits         329629     339208      +9579     
+ Misses        99214      89617      -9597     
- Partials      20195      20566       +371
Flag Coverage Δ
integration 48.8580% <0.0000%> (?)
unit 72.6176% <22.2222%> (+0.1093%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3231% <ø> (+6.7625%) ⬆️

AilinKid
AilinKid commented Sep 24, 2024
View reviewed changes
pkg/planner/core/logical_datasource.go Outdated
// ************************ start implementation of HashEquals interface ************************

// Hash64 implements base.HashEquals interface.
func (ds *DataSource) Hash64(h base2.Hasher) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winoros @elsa0520
current logical operator only care about some key elements to do the hash64

for example: astHints are not considered here, the start point is what the minimum we need to determinate this ds is unique one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure for other elements, agile for adjustment in future

@AilinKid
Copy link
Contributor Author

/retest-required

@tiprow tiprow
Copy link

tiprow bot commented Sep 25, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid
.
748dae6 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
8e1cf6a 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
42eee55 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
c1f17a0 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
9dbce8c 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
2f45059 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
b1c1eb8 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
4d733b4 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
025206d 
Signed-off-by: arenatlx <[email protected]>
@AilinKid
.
3c7fcf8 
Signed-off-by: arenatlx <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 07:24:49.456610822 +0000 UTC m=+1117244.876823834: ☑️ agreed by winoros.
  • 2024-10-10 07:53:42.26406466 +0000 UTC m=+1118977.684277672: ☑️ agreed by hawkingrei.

@AilinKid
Copy link
Contributor Author

/retest-required

@tiprow tiprow
Copy link

tiprow bot commented Oct 10, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot merged commit 5e8bb8e into pingcap:master Oct 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AilinKid @hawkingrei @winoros