session: fix wrong etcd mutex key #56371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wjhuang2016 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56371 +/- ##
================================================
+ Coverage 73.3867% 75.5860% +2.1992%
================================================
Files 1620 1623 +3
Lines 447041 450083 +3042
================================================
+ Hits 328069 340200 +12131
+ Misses 98877 89376 -9501
- Partials 20095 20507 +412
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: wjhuang2016 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
tangenta
reviewed
Sep 27, 2024
Co-authored-by: tangenta <[email protected]>
wjhuang2016
changed the title
lance6716
approved these changes
Sep 29, 2024
tangenta
approved these changes
Sep 29, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
wjhuang2016
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
wjhuang2016
added
the
needs-cherry-pick-release-8.4
|
In response to a cherrypick label: cannot checkout |
wjhuang2016
removed
the
needs-cherry-pick-release-8.4
EricZequan
pushed a commit
to EricZequan/tidb
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #56375
Problem Summary:
Used the wrong mutex key.
What changed and how does it work?
Check List
Tests
Start a v8.3.0 tidb cluster and upgrade.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.