planner: make pattern match case-insensitive for some infoschema tables #56378
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56378 +/- ##
================================================
+ Coverage 73.3867% 75.5318% +2.1450%
================================================
Files 1620 1622 +2
Lines 447041 448501 +1460
================================================
+ Hits 328069 338761 +10692
+ Misses 98877 89230 -9647
- Partials 20095 20510 +415
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tangenta
added
the
needs-cherry-pick-release-8.4
| @@ -661,6 +672,13 @@ func findTableAndSchemaByName( | |||
| schemaSlice = append(schemaSlice, st.schema) | |||
| tableSlice = append(tableSlice, st.table) | |||
| } | |||
| sort.Slice(schemaSlice, func(i, j int) bool { | |||
There was a problem hiding this comment.
We only need to sort by schema name?
| @@ -721,6 +739,13 @@ func findSchemasForTables( | |||
| remains = append(remains, tbl) | |||
| } | |||
| } | |||
| sort.Slice(schemaSlice, func(i, j int) bool { | |||
There was a problem hiding this comment.
Can we create a new slice to store tables instead of directly modifing input slice?
There was a problem hiding this comment.
The input slice is not used by anyone else. Let me add some comments for this.
|
@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
@tangenta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, joechenrh, tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: cannot checkout |
tangenta
removed
the
needs-cherry-pick-release-8.4
What problem does this PR solve?
Issue Number: close #56377
Problem Summary:
There are two problems with #55844:
LIKE '%T'cannot match"tt".What changed and how does it work?
ListSchemasAndTablesto make test stable.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.