Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: process DML changes in the new PQ #56383

Merged
merged 1 commit into from
Oct 8, 2024
Merged

statistics: process DML changes in the new PQ #56383

merged 1 commit into from
Oct 8, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Sep 27, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

This PR split from #55889.

This pull request addresses the processing of DML changes from the stats cache. It is a continuation of the work started in PR #55889.

  • Added functionality to process DML changes, including fetching and updating timestamps, and handling table stats.
  • Added tests for processing DML changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.16667% with 165 lines in your changes missing coverage. Please review.

Project coverage is 75.6691%. Comparing base (b520f61) to head (27e5fbf).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56383        +/-   ##
================================================
+ Coverage   73.3867%   75.6691%   +2.2823%     
================================================
  Files          1620       1646        +26     
  Lines        447041     466897     +19856     
================================================
+ Hits         328069     353297     +25228     
+ Misses        98877      92254      -6623     
- Partials      20095      21346      +1251
Flag Coverage Δ
integration 50.7087% <0.5555%> (?)
unit 72.7466% <54.1666%> (+0.2683%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.1826% <100.0000%> (+6.6533%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2024
@Rustin170506
Copy link
Member Author

/retest

Rustin170506
Rustin170506 commented Sep 29, 2024
View reviewed changes
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 29, 2024
Rustin170506
Rustin170506 commented Sep 29, 2024
View reviewed changes
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 30, 2024
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-process-dml-changes branch 7 times, most recently from ed58e1e to d9a0403 Compare October 1, 2024 08:40
@Rustin170506 Rustin170506 force-pushed the rustin-patch-process-dml-changes branch 5 times, most recently from 82d5e74 to b8ec638 Compare October 2, 2024 02:45
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 mentioned this pull request Oct 2, 2024
Merged
13 tasks
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-process-dml-changes branch 10 times, most recently from bfbcbd4 to 721efd4 Compare October 7, 2024 05:17
@Rustin170506
statistics: process DML changes in the new PQ
27e5fbf 
fix: do not maintain time window in the queue

refactor: make lint happy

docs: add FIXME

refactor: rename to rebuildWithoutLock

fix

docs: add more comments

fix

fix

fix

fix

fix

fix

fix

fix

feat: add jobHooks

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@Rustin170506 Rustin170506 force-pushed the rustin-patch-process-dml-changes branch from 721efd4 to 27e5fbf Compare October 7, 2024 05:19
Rustin170506
Rustin170506 commented Oct 7, 2024
View reviewed changes
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 06:52:59.860535685 +0000 UTC m=+251335.280748692: ☑️ agreed by qw4990.
  • 2024-10-08 05:29:02.697353272 +0000 UTC m=+937498.117566283: ☑️ agreed by time-and-fate.

@Rustin170506
Copy link
Member Author

/retest

1 similar comment
@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1455d45 into pingcap:master Oct 8, 2024
24 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-process-dml-changes branch October 8, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rustin170506 @qw4990 @time-and-fate