planner: play replay load restore the table with foreign key with right order. #56457

hawkingrei · 2024-10-06T09:45:33Z

What problem does this PR solve?

Issue Number: close #56456

Problem Summary:

What changed and how does it work?

when restoring the table schema, some tables have these dependencies between each other. so we need to disable the ForeignKeyChecks to create table.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: play replay load restore the table with foreign key with right order

hawkingrei · 2024-10-06T09:53:51Z

/check-issue-triage-complete

codecov · 2024-10-06T10:00:25Z

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.1929%. Comparing base (025c2a3) to head (ff7d806).
Report is 32 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56457         +/-   ##
=================================================
- Coverage   73.3320%   57.1929%   -16.1391%     
=================================================
  Files          1629       1778        +149     
  Lines        449708     643471     +193763     
=================================================
+ Hits         329780     368020      +38240     
- Misses        99711     250331     +150620     
- Partials      20217      25120       +4903

Flag	Coverage Δ
integration	`39.1578% <10.2564%> (?)`
unit	`72.5123% <71.7948%> (+0.0431%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.0553% <ø> (+17.4638%)`	⬆️

hawkingrei · 2024-10-08T03:50:56Z

/retest

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2024-10-16T06:45:40Z

/retest

winoros · 2024-10-16T07:03:44Z

pkg/executor/plan_replayer.go

+	origin := e.Ctx.GetSessionVars().ForeignKeyChecks
+	e.Ctx.GetSessionVars().ForeignKeyChecks = false
+	defer func() {
+		e.Ctx.GetSessionVars().ForeignKeyChecks = origin
+	}()


Add a comment for future reader

I have added it.

YangKeao

LGTM

ti-chi-bot · 2024-10-16T07:05:51Z

[LGTM Timeline notifier]

Timeline:

2024-10-16 07:03:55.76817676 +0000 UTC m=+427432.917086591: ☑️ agreed by winoros.
2024-10-16 07:05:50.165617936 +0000 UTC m=+427547.314527765: ☑️ agreed by YangKeao.

ti-chi-bot · 2024-10-16T07:14:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,lance6716,winoros]
~~pkg/domain/OWNERS~~ [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hawkingrei · 2024-10-16T07:50:57Z

/retest

ti-chi-bot · 2024-10-17T02:29:18Z

In response to a cherrypick label: new pull request created to branch release-8.1: #56692.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-10-17T02:29:21Z

In response to a cherrypick label: new pull request created to branch release-7.5: #56693.

Signed-off-by: ti-chi-bot <[email protected]>

…ht order. (#56457) (#56693) close #56456

…ht order. (#56457) (#56692) close #56456

hawkingrei · 2024-11-04T06:53:24Z

/cherrypick release-7.1

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-11-04T06:54:08Z

@hawkingrei: new pull request created to branch release-7.1: #57098.

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…ht order. (#56457) (#57098) close #56456

hawkingrei removed the do-not-merge/needs-triage-completed label Oct 6, 2024

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2024

hawkingrei marked this pull request as draft October 10, 2024 02:04

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024

hawkingrei marked this pull request as ready for review October 12, 2024 09:13

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2024

hawkingrei added 4 commits October 12, 2024 17:17

update

e6a69db

Signed-off-by: Weizhen Wang <[email protected]>

update

bc37ec0

Signed-off-by: Weizhen Wang <[email protected]>

update

aca89e0

Signed-off-by: Weizhen Wang <[email protected]>

update

f0f16b8

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei force-pushed the 56456 branch from c43239a to f0f16b8 Compare October 12, 2024 09:20

hawkingrei added 5 commits October 15, 2024 15:35

fix test

d8cfc58

update

b25460a

Signed-off-by: Weizhen Wang <[email protected]>

update

45037be

Signed-off-by: Weizhen Wang <[email protected]>

update

ff70b15

Signed-off-by: Weizhen Wang <[email protected]>

update

dc16f70

Signed-off-by: Weizhen Wang <[email protected]>

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 15, 2024

update

cd96e07

Signed-off-by: Weizhen Wang <[email protected]>

update

c7ea536

Signed-off-by: Weizhen Wang <[email protected]>

winoros approved these changes Oct 16, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2024

YangKeao approved these changes Oct 16, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024

*: enable intrange linter

ff7d806

lance6716 approved these changes Oct 16, 2024

View reviewed changes

ti-chi-bot bot added the approved label Oct 16, 2024

ti-chi-bot bot merged commit 53a4c3e into pingcap:master Oct 16, 2024
25 checks passed

ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Oct 17, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 17, 2024

This is an automated cherry-pick of pingcap#56457

3993d4f

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Oct 17, 2024

planner: play replay load restore the table with foreign key with right order. (#56457) #56692

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 17, 2024

This is an automated cherry-pick of pingcap#56457

b8636b4

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Oct 17, 2024

planner: play replay load restore the table with foreign key with right order. (#56457) #56693

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2024

planner: play replay load restore the table with foreign key with rig…

df753d1

…ht order. (#56457) (#56693) close #56456

ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2024

planner: play replay load restore the table with foreign key with rig…

c08ecf1

…ht order. (#56457) (#56692) close #56456

hawkingrei deleted the 56456 branch November 4, 2024 06:53

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 4, 2024

This is an automated cherry-pick of pingcap#56457

25dea3f

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Nov 4, 2024

planner: play replay load restore the table with foreign key with right order. (#56457) #57098

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 4, 2024

planner: play replay load restore the table with foreign key with rig…

4fec22b

…ht order. (#56457) (#57098) close #56456

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: play replay load restore the table with foreign key with right order. #56457

planner: play replay load restore the table with foreign key with right order. #56457

hawkingrei commented Oct 6, 2024 •

edited

Loading

hawkingrei commented Oct 6, 2024

codecov bot commented Oct 6, 2024 •

edited

Loading

hawkingrei commented Oct 8, 2024

hawkingrei commented Oct 16, 2024

winoros Oct 16, 2024

hawkingrei Oct 16, 2024

YangKeao left a comment

ti-chi-bot bot commented Oct 16, 2024

ti-chi-bot bot commented Oct 16, 2024

hawkingrei commented Oct 16, 2024

ti-chi-bot commented Oct 17, 2024

ti-chi-bot commented Oct 17, 2024

hawkingrei commented Nov 4, 2024

ti-chi-bot commented Nov 4, 2024

planner: play replay load restore the table with foreign key with right order. #56457

planner: play replay load restore the table with foreign key with right order. #56457

Conversation

hawkingrei commented Oct 6, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

hawkingrei commented Oct 6, 2024

codecov bot commented Oct 6, 2024 • edited Loading

Codecov Report

hawkingrei commented Oct 8, 2024

hawkingrei commented Oct 16, 2024

winoros Oct 16, 2024

Choose a reason for hiding this comment

hawkingrei Oct 16, 2024

Choose a reason for hiding this comment

YangKeao left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Oct 16, 2024

hawkingrei commented Oct 16, 2024

ti-chi-bot commented Oct 17, 2024

ti-chi-bot commented Oct 17, 2024

hawkingrei commented Nov 4, 2024

ti-chi-bot commented Nov 4, 2024

hawkingrei commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading