session: upgrade from old cluster infoschema v2 should not be used

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #56544

Problem Summary:

What changed and how does it work?

Upgrade from old version tidb, infoschema v2 should not be used.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

See the steps described in the issue.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.1543%. Comparing base (5e8bb8e) to head (4f69950).
Report is 69 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56545         +/-   ##
=================================================
- Coverage   73.3611%   58.1543%   -15.2069%     
=================================================
  Files          1626       1755        +129     
  Lines        449213     642418     +193205     
=================================================
+ Hits         329548     373594      +44046     
- Misses        99482     244780     +145298     
- Partials      20183      24044       +3861     

Flag	Coverage Δ
integration	39.3596% <0.0000%> (?)
unit	74.0056% <57.1428%> (+1.5407%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	63.3659% <ø> (+17.8020%)	⬆️

[tiancaiamao]

/retest

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

/ok-to-test

[D3Hunter]

if there's no such row in global_variables

when we execute this statement, the first domain and infocache has already started, the infocache is still v2 ?

[tiancaiamao]

Later when infoschema reload it would detect the new tidb_schema_cache_size value and change to v1 @D3Hunter

[GMHDBJD]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-12 02:48:57.651007461 +0000 UTC m=+66534.799917294: ☑️ agreed by D3Hunter.
• 2024-10-12 04:04:49.354800363 +0000 UTC m=+71086.503710193: ☑️ agreed by GMHDBJD.

[yudongusa]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, D3Hunter, GMHDBJD, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [3pointer]
• pkg/session/OWNERS [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.4: #56738.